Agile Zone is brought to you in partnership with:

Ayende Rahien is working for Hibernating Rhinos LTD, a Israeli based company producing developer productivity tools for OLTP applications such as NHibernate Profiler (nhprof.com), Linq to SQL Profiler(l2sprof.com), Entity Framework Profiler (efprof.com) and more. Ayende is a DZone MVB and is not an employee of DZone and has posted 468 posts at DZone. You can read more from them at their website. View Full User Profile

What where they THINKING? The github merge button is STUPID

05.06.2011
| 12554 views |
  • submit to reddit

I just love git pull requests, but the new behavior from GitHub is beyond moronic. Take a look at a typical pull request:

image

The problem is that clicking on this button would actually merge the changes to the public repository. I don’t know about you, but there are very few cases where this is what I want to do.

In 99.9999% of the cases, I want to merge this locally to see what the bloody changes are, run some tests, maybe modify the changes before I am taking them.  In this case, this particular pull request contains a failing test. I never want to commit that to the public repo automatically.

What is worse is that I now need to manually construct the pull command in the command line, whereas GitHub previously offered the option to generate that for me, which I liked much more.

References
Published at DZone with permission of Ayende Rahien, author and DZone MVB. (source)

(Note: Opinions expressed in this article and its replies are the opinions of their respective authors and not those of DZone, Inc.)

Comments

Cedric Beust replied on Fri, 2011/05/06 - 12:12pm

You make it sound as if they removed all the other ways to merge. They didn't, feel free to ignore the button and pull things locally before merging, but this button is very useful for changes that you know won't have any negative impact, such as updating documentation, fixing obvious bugs or adding simple functionalities.

Liezel Jandayan replied on Wed, 2013/01/23 - 7:03am

 That's the look for an online newspaper. For newspaper there is the need for a large image left to the post. For javalobby it just takes alot of space for nothing.-Donald Leon Farrow

Stephen Gacho replied on Fri, 2013/01/25 - 4:37am

 However, he believes that unit testing is still lacking in concurrent code.  He also had an un-conference that met in Crete.  I would jump at the chance to attend that!-Phil Melugin 

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.