Javalobby - Comments for "Create a Yahtzee Dice Roller and Scorer in Compiled JavaFX Script"

Wow! That code looks almost

a6767 — Thu, 27 Mar 2008 14:25:04 -0400

Wow!

That code looks almost like a dfm file (Delphi)

object FSeg_Soc: TFSeg_Soc
  Left = 217
  Top = 115
  HelpContext = 36
  BorderIcons = [biSystemMenu, biMaximize]
  BorderStyle = bsSingle
  ClientHeight = 352
  ClientWidth = 544
  Color = clBtnFace
  Font.Charset = DEFAULT_CHARSET
  Font.Color = clWindowText
  Font.Height = -11
  Font.Name = 'MS Sans Serif'
  Font.Style = []
  HelpFile = 'Ayudas\SegSoc.chm'
  KeyPreview = True
  OldCreateOrder = True
  Position = poScreenCenter
  OnActivate = FormActivate
  OnClose = FormClose
  OnCreate = FormCreate
  OnDestroy = FormDestroy
  OnKeyDown = FormKeyDown
  PixelsPerInch = 96
  TextHeight = 13
  object DBGrid1: TDBGrid
    Left = 0
    Top = 210
    Width = 544
    Height = 142
    Align = alClient
    DataSource = DataBaseAux
    Options = [dgEditing, dgTitles, dgIndicator, dgColLines, dgRowLines, dgConfirmDelete, dgCancelOnExit]
    PopupMenu = PopupMenu1
    TabOrder = 0
    TitleFont.Charset = DEFAULT_CHARSET
    TitleFont.Color = clWindowText
    TitleFont.Height = -11
    TitleFont.Name = 'MS Sans Serif'
    TitleFont.Style = []
    OnColExit = DBGrid1ColExit
    OnEditButtonClick = DBGrid1EditButtonClick
    OnKeyDown = DBGrid1KeyDown
    OnKeyPress = DBGrid1KeyPress
    Columns = <
      item
        ButtonStyle = cbsEllipsis
        Expanded = False
        FieldName = 'EMPDSDE'
        Title.Alignment = taCenter
        Title.Caption = 'Enterprise(D)'
        Visible = True
      end
      item
        ButtonStyle = cbsEllipsis
        Expanded = False
        FieldName = 'EMPAST'
        Title.Alignment = taCenter
        Title.Caption = 'Enterprise(H)'
        Visible = True
      end
      item
        Color = 8454143
        Expanded = False
        FieldName = 'TYPE'
        ReadOnly = True
        Title.Alignment = taCenter
        Width = 67
        Visible = True
      end
      item
        Color = 8454143
        Expanded = False
        FieldName = 'WHO'
        ReadOnly = True
        Width = 312
        Visible = True
      end>
  end
  object CoolBar1: TCoolBar
    Left = 0
    Top = 0

It looks good Jim, but I'm

aalmiray — Thu, 27 Mar 2008 12:41:50 -0400

It looks good Jim, but I'm not quite convinced, it took 443 lines of code (sans comments) to get this example working, surely surrendering some formatting will shrink that number, but that is not exactly the point. I mean there is repetition while laying out the components of the GroupPanel: first rows are defined as vars, then they are assigned to the rows property of the panel, lastly they are used as constraints for each label. the jfx looks like its doing something like the following under the covers

GroupPanel gp = new GroupPanel();
// if Row constructor accepts an alignment as parameter
Row fiveOfKindRow = new Row( Alignment.BASELINE ); 
// if Row constructor does not accept an alignment parameter
Row largeStraightRow = new Row();
largeStraightRow.setAlignment( Alignment.BASELINE ); 
...
gp.addRow( fiveOfKindRow );
gp.addRow( largeStraightRow );
/* or it may be like
 gp.setRows( new Row[]{ fiveOfKindRow, largeStraightRow, ...} )
*/
gp.getContentPane().add( new SimpleLabel(...),
        new RowColumnConstraint(fiveOfKindRow,labelsColumn) );

I'm surely biased when I say that a builder (not necessarily a Groovy one, thought it doesn't hurt) is best suited for this task, as it will keep the DRY-ness in check, as with this approach the code may look like the following one

GroupPanel { 
   // we fix the # of columns first
   columns {
      Column( alignment: Alignment.TRAILING )
      Column( alignment: Alignment.LEADING )
   }
   // add the first row
   Row( alignment: alignment.BASELINE ) {
      SimpleLabel( text: "Five of a Kind (Yathzee):", font: evalFont )
      SimpleLabel( font: evalFont, text: bind if (model.fiveOfKind)
                               "{model.fineOfKindScore}" else 'N/A" )
   }
   // add more rows
}

My $0.02