Javalobby - Comments for "The secret life of a DefaultTreeModel"

I wish I had something like

soronthar — Sun, 06 Apr 2008 19:16:57 -0400

I wish I had something like this two years ago. Good work! :D

Jeanette,Thanks for the

cfagan — Wed, 26 Mar 2008 14:13:26 -0400

Jeanette,

Thanks for the feedback. I'll change the bulk child insert to just add a large block of children and not grandchildren. I'll also add in a block for the valueForPathChanged method. Mostly this tutorial grew out of my frustration with a software system that used a node based update system. I can't tell you how many "update causes ... in main tree" bugs I had to deal with as a result.

Thanks again for the feedback.

Collin

doohhh .. lost my first

jw54674 — Wed, 26 Mar 2008 12:43:50 -0400

doohhh .. lost my first trial to comment, so here#s a shorter version :-(

Collin,

always good to see propagation of best-practices :-) Just two minor points:

- the insert-many nodes example is a bit off target, IMO: basically it's inserting grandchildren. As tree notification is about children only, there's is no need to care about them (and no need for a structureChanged) - it's good enough to nodify the insertion of the two new children (odd and even)

<code>

model.nodesWereInserted(node, new int[] {node.getIndex(odd), node.getIndex(even)});

</code>

so it's this one notification vs. two if using the model methods. Not so much of an incentive to go a more error-prone path. Obviously a judgement call :-)

- your change example can be done directly through the model (after all, we know we have DefaultMTNs :-)

<code>

tree.getModel().valueForPathChanged(currentSelection, "This is a very loooooooooooooooog string");

</code>

Jeanette